Account for offset when usm_ndarray constructor is provided buffer that is a usm_ndarray#2226
Closed
ndgrigorian wants to merge 1 commit intomasterfrom
Closed
Account for offset when usm_ndarray constructor is provided buffer that is a usm_ndarray#2226ndgrigorian wants to merge 1 commit intomasterfrom
usm_ndarray constructor is provided buffer that is a usm_ndarray#2226ndgrigorian wants to merge 1 commit intomasterfrom
Conversation
this necessitates restricting the constructor to no longer permit arrays that aren't contiguous
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_104 ran successfully. |
7 tasks
antonwolfy
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 17, 2026
The PR adds passing the buffer offset to `usm_ndarray` constructor. This is fast and straightforward solution. The complete fix needs to be implemented in dpctl in scope of [dpctl#2226](IntelPython/dpctl#2226).
github-actions bot
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 17, 2026
The PR adds passing the buffer offset to `usm_ndarray` constructor. This is fast and straightforward solution. The complete fix needs to be implemented in dpctl in scope of [dpctl#2226](IntelPython/dpctl#2226). 6ff93b9
Collaborator
Author
|
This PR is defunct, as it could potentially introduce undefined behavior with some strided arrays (most obviously reversed arrays, i.e., NumPy works around this issue by not allowing these arrays as buffers in their constructors, but such a change would be significant and require a lot of work in dpctl. As such, instead, it will be recommended that for power users, when using a buffer that is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes accounting for the offset when
usm_ndarrayconstructor is givenbuffer=xwherexis ausm_ndarray.This means that when a
xis a view, and in particular a view on memory which does not start at the same place as its base array, the memory will start from the same displaced position as the view. For example,where previously,
bwould not have changed at all and the 0 would have appeared ata[1].This has also necessitated disallowing views which are not contiguous as arguments to the
usm_ndarrayconstructor, which aligns with NumPy.